----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/#review109029 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 321) <https://reviews.apache.org/r/39782/#comment168436> Cool! Mind moving this down on the line below and add a ':', so it becomes: ``` // Updates the value of LD_LIBRARY_PATH environment variable. // NOTE: that setting this is only useful for child processes. Neither the Linux nor the OS X // linkers dynamically update their search path after a process is launched. ``` - Niklas Nielsen On Nov. 26, 2015, 6:06 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39782/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 6:06 a.m.) > > > Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and > Till Toenshoff. > > > Bugs: MESOS-3725 > https://issues.apache.org/jira/browse/MESOS-3725 > > > Repository: mesos > > > Description > ------- > > Add a comment for os::libraries::setPaths. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 > > Diff: https://reviews.apache.org/r/39782/diff/ > > > Testing > ------- > > No code changes. > > > Thanks, > > James Peach > >
