----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109238 -----------------------------------------------------------
Bad patch! Reviews applied: [40431] Failed command: ./support/apply-review.sh -n -r 40431 Error: 2015-12-08 01:04:32 URL:https://reviews.apache.org/r/40431/diff/raw/ [12531/12531] -> "40431.patch" [1] Successfully applied: Move RoleInfo message out of allocator.proto Currently role protobuf is defined in allocator.proto due to only the traditional DRF allocator uses roles as it’s first level of hierarchy, I think we should move it out and define it in a separated file as quota had in dynamic roles project, because role protobuf will also be used by master to persist. Review: https://reviews.apache.org/r/40431 include/mesos/role/role.hpp:1: A license header should appear on the file's first line starting with '// Licensed'.: /** Total errors found: 1 Checking 9 files Failed to commit patch - Mesos ReviewBot On Dec. 7, 2015, 10:12 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40469/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 10:12 a.m.) > > > Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu. > > > Bugs: MESOS-3956 > https://issues.apache.org/jira/browse/MESOS-3956 > > > Repository: mesos > > > Description > ------- > > Update Allocator interface to support dynamic roles > > > Diffs > ----- > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 99c742906874c30c39c159e58a65277ade3c07fd > src/master/allocator/mesos/hierarchical.cpp > 5da825a1d578a9ee40b4985378fddb3c5fb3b416 > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > > Diff: https://reviews.apache.org/r/40469/diff/ > > > Testing > ------- > > Make check successfully. > > > Thanks, > > Yong Qiao Wang > >
