> On Dec. 7, 2015, 11:51 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/process.cpp, lines 3218-3220 > > <https://reviews.apache.org/r/38000/diff/19/?file=1155108#file1155108line3218> > > > > If this is an internal invariant, how about adding a `CHECK` here?
How would the check be liked? if you read the comment it either has a principal because otherwise authentication failed or there is no principal because authentication wasn't needed at all. I changed the comment though. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109203 ----------------------------------------------------------- On Dec. 7, 2015, 3:14 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38000/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 3:14 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3233 > https://issues.apache.org/jira/browse/MESOS-3233 > > > Repository: mesos > > > Description > ------- > > Adds functions which allow libprocess users to register HTTP authenticators. > Overloads `ProcesBase::route()` to allow for registering of authenticating > endpoints. > Includes tests. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > a03824c061c4a0eb865b163999a763635e56744c > 3rdparty/libprocess/include/process/process.hpp > 81c094414d4d5ac5eb593df2a6d14aaacb19a826 > 3rdparty/libprocess/src/process.cpp > e93709d3bb4ac588457bb9331fc05ec5ab539f6d > 3rdparty/libprocess/src/tests/http_tests.cpp > 2de75ca1c7e224c36b534c368e7379dc158aa5bb > > Diff: https://reviews.apache.org/r/38000/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
