-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
-----------------------------------------------------------

(Updated Dec. 8, 2015, 7:24 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-3065
    https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
-------

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs (updated)
-----

  src/tests/persistent_volume_tests.cpp 
01b3c13751a5558d5f06edb8f650c8644dc54486 

Diff: https://reviews.apache.org/r/40256/diff/


Testing (updated)
-------

This is the sixth in a chain of 7 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.


Thanks,

Greg Mann

Reply via email to