-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41114/#review109470
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41114]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 9, 2015, 1:36 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41114/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 1:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Michael Park.
> 
> 
> Bugs: MESOS-4103
>     https://issues.apache.org/jira/browse/MESOS-4103
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Lots of places in the WebUI only shows cpus and mem, but not disk. This fixes 
> it.
> 
> Also, we were showing "0" disk used when the statistics received from the 
> slave didn't contain disk metrics, but I think it's misleading. I fixed it to 
> instead show nothing to make it clear that the value is unknown.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html 
> 8c6e5e4e02a769fd0098150b0dcba69f43b20232 
>   src/webui/master/static/frameworks.html 
> 44ef2e55c1e37bb74f769842fe1babffe31a8ea9 
>   src/webui/master/static/home.html 4fc64c0aea558fca18083dc317f8370670d7a4d3 
>   src/webui/master/static/js/controllers.js 
> ccf5c31715e298e96f493cce58921bfe6b16b779 
>   src/webui/master/static/js/dashboard.js 
> 5b1769c8dc731d85a7badfaa44794774da95000c 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
>   src/webui/master/static/slave_executor.html 
> 7c66405090f46f89bdd29806a58c05dc76c0ad23 
>   src/webui/master/static/slave_framework.html 
> 90eff2f3b4de08f98283b27e1635ba23a855e488 
> 
> Diff: https://reviews.apache.org/r/41114/diff/
> 
> 
> Testing
> -------
> 
> Tested locally by running a local master, slave and mesos-execute with disk 
> resources.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to