----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/#review109529 -----------------------------------------------------------
It would be great to have a test for "/roles" endpoint when: - quota is set for a role and - some resources are reserved dynamically for a role. src/tests/role_tests.cpp (line 219) <https://reviews.apache.org/r/41076/#comment169096> Third person singular, please : ). Also below. src/tests/role_tests.cpp (line 327) <https://reviews.apache.org/r/41076/#comment169097> I would suggest to pull the role name into a constant for readability. src/tests/role_tests.cpp (line 402) <https://reviews.apache.org/r/41076/#comment169099> Do you want to check the status code as well using `AWAIT_EXPECT_RESPONSE_STATUS_EQ`? src/tests/role_tests.cpp (line 463) <https://reviews.apache.org/r/41076/#comment169100> Again, how about pulling these roles into constants? - Alexander Rukletsov On Dec. 9, 2015, 5:54 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41076/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 5:54 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg > Mann, and Yong Qiao Wang. > > > Bugs: MESOS-4085 > https://issues.apache.org/jira/browse/MESOS-4085 > > > Repository: mesos > > > Description > ------- > > Also added tests for the "/role" HTTP endpoint. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > fb214a829a57529d3f5c49730ae9733f53e622ca > src/tests/role_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41076/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
