-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109559
-----------------------------------------------------------



src/CMakeLists.txt (lines 223 - 226)
<https://reviews.apache.org/r/40951/#comment169132>

    Actually, I think I should have been more diligent about reviewing 
carefully here.
    
    I think that this might make more sense down when we set `MESOS_SRC` with 
all the other variables listed here.
    
    Per our conversation, I think your intuition that we really want to append 
this to `AGENT_SRC` is actually totally right, but my counterpoint is that we 
actually want the `AGENT_SRC` to include a bunch of these other source groups 
anyway, so appending to the `AGENT_SRC` really doesn't have too many advantages 
in my view.


- Alex Clemmer


On Dec. 9, 2015, 3:45 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 3:45 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> -------
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Reply via email to