----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109562 -----------------------------------------------------------
src/CMakeLists.txt (lines 267 - 286) <https://reviews.apache.org/r/40951/#comment169134> Sorry, one more thing. :) The definition of `MESOS_SRC` is split up by these two definitions. Do you think it makes more sense to not split up this definition by putting this block of code somewhere else? - Alex Clemmer On Dec. 9, 2015, 3:45 a.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40951/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 3:45 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > Initial set of source files missing for cmake agent binary. > > > Diffs > ----- > > src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef > > Diff: https://reviews.apache.org/r/40951/diff/ > > > Testing > ------- > > Tested to make sure library builds successfully. > > > Thanks, > > Diana Arroyo > >