-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review109593
-----------------------------------------------------------


Few things you need to do before this can get committed

1) Send an email to the mailing list announcing this change. I hope none of the 
existing schedulers crash when they receive this callback, but we want to make 
sure.
2) Update the upgrade and changelog docs.
3) Add a NOTE to the executorLost() (and even slaveLost()) method in the 
C++/Java/Python interfaces that this is not reliably delivered.

Another, easier option of course is to not do this change in the scheduler 
driver and live with the fact that this event is only delivered to HTTP 
schedulers and not driver based schedulers.


src/sched/sched.cpp (lines 219 - 223)
<https://reviews.apache.org/r/40429/#comment169169>

    pull this up to #209.



src/sched/sched.cpp (lines 221 - 222)
<https://reviews.apache.org/r/40429/#comment169170>

    flip the order of these two.



src/sched/sched.cpp (line 1053)
<https://reviews.apache.org/r/40429/#comment169171>

    move this upto #1009.



src/sched/sched.cpp (line 1075)
<https://reviews.apache.org/r/40429/#comment169172>

    remove "!"



src/tests/scheduler_event_call_tests.cpp (line 615)
<https://reviews.apache.org/r/40429/#comment169175>

    Can you also add/update a test that uses scheduler driver to ensure that 
this callback is called Perhaps, 
MasterSlaveReconciliationTest.SlaveReregisterTerminatedExecutor ?
    
    I would imagine you would need to update a lot more tests that don't expect 
this callback but now get this. It's likely that GMOCK only throws a warning 
but doesn't error out. You can see the warnings if you run the tests *without* 
verbose mode.


- Vinod Kone


On Nov. 18, 2015, 9:50 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 9:50 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
>     https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
>   src/tests/scheduler_event_call_tests.cpp 
> 39f67a8243db8073d1c9c92c7aeb71854143131d 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> -------
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to