-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40195/
-----------------------------------------------------------
(Updated Dec. 9, 2015, 11:09 p.m.)
Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van
Remoortere, and Joseph Wu.
Bugs: MESOS-3134
https://issues.apache.org/jira/browse/MESOS-3134
Repository: mesos
Description
-------
On Windows, if you attempt to commit an empty changeset, the commit hooks will
attempt to lint the entire repository. This is because we pass blank arguments
to the call to `xargs` that kicks off the C++ linter (e.g., in
`support/pre-commit`). In the git bash, the default behavior of blank arguments
is *not* to ignore them, as it is on certain other platforms. Note that the
`-r` flag is provided to avoid this behavior, but it is only available on
some platforms, and hence is inadmissable here.
Hence, our solution is to check if the results of `git diff` are empty, and
only call `mesos-style.py` if not.
Diffs
-----
support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3
support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d
Diff: https://reviews.apache.org/r/40195/diff/
Testing
-------
Branches tested manually.
Thanks,
Alex Clemmer
