> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote:
> > Are you also planning to update 
> > https://github.com/apache/mesos/blob/master/docs/oversubscription.md ?

Already in review: https://reviews.apache.org/r/41042/  (:


Thx for detailed review i will fix the issues soon.


> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 1602-1603
> > <https://reviews.apache.org/r/40617/diff/5/?file=1155925#file1155925line1602>
> >
> >     how come the fixed estimator only has a source file and this one has a 
> > header too?

I needed Load QoS controller interface (in header file) for the unit tests in 
`oversubscription_tests.hpp`. Fixed estimator was tested as integration test. 
(Loaded as module and checking status update message).


> On Dec. 9, 2015, 10:46 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 1674
> > <https://reviews.apache.org/r/40617/diff/5/?file=1155925#file1155925line1674>
> >
> >     do we need this? i don't see slave/resource_estimators/fixed.cpp here?

See comment above. I need that for my unit tests. Fixed estimator has only 
integration test.


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40617/#review109597
-----------------------------------------------------------


On Dec. 8, 2015, 11:16 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40617/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 11:16 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-4076
>     https://issues.apache.org/jira/browse/MESOS-4076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Load QoS Controller for the simple eviction when system load is above 
> configured system load threshold for 5min and 15min:
> - Made os::loadavg called from the lambda and passed via the contructor.
> - Added unit test.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
>   src/slave/qos_controllers/load.hpp PRE-CREATION 
>   src/slave/qos_controllers/load.cpp PRE-CREATION 
>   src/tests/oversubscription_tests.cpp 
> 0333281c247dd182860a49f39be791c00679bf6b 
> 
> Diff: https://reviews.apache.org/r/40617/diff/
> 
> 
> Testing
> -------
> 
> make check
> run mesos with org_apache_mesos_LoadQoSController module included.
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to