----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41113/#review109812 -----------------------------------------------------------
NOTE: this patch may not be necessary, as a simpler workaround has been found. I'm leaving it open for now, but may discard in the near future. - Greg Mann On Dec. 9, 2015, 11:59 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41113/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 11:59 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Neil Conway. > > > Bugs: MESOS-4003 > https://issues.apache.org/jira/browse/MESOS-4003 > > > Repository: mesos > > > Description > ------- > > This patch adds the message `IsolatorRecoveryInfo` and makes it the sole > parameter of `Isolator::recover()`, in order to facilitate the future > addition of parameters without breaking the interface. > > In addition to the two existing parameters of `Isolator::recover()`, a third > member was added to `IsolatorRecoveryInfo`: the agent's `work_dir`. This is > useful for the network storage DVD isolator > (https://github.com/emccode/mesos-module-dvdi) in particular. > > > Diffs > ----- > > include/mesos/slave/isolator.hpp 95a2933988ea7c9b9404df5e12031f134712b2b5 > include/mesos/slave/isolator.proto d2032adf9336119ed8e1ff3c813d657d70331b67 > src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023 > src/common/protobuf_utils.cpp 6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 > src/slave/containerizer/mesos/containerizer.cpp > 6dad2e858b68cf47e048d49d34af4fa4cb3b6841 > src/slave/containerizer/mesos/isolator.hpp > 937f253656d36ed10b47ceeb0b6101f212e65586 > src/slave/containerizer/mesos/isolator.cpp > 493b5dd26cf0e8f986381a502cfa6d1dde6573d4 > src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp > 123b9ed3ccaebcd5da24fc62ff7a92d4a81ed760 > src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp > 3b95e195ad704f163c245175390d9a26bde7e17c > src/slave/containerizer/mesos/isolators/cgroups/mem.hpp > 09952369c72d3c6322ae7a1c73cd68226d452ad2 > src/slave/containerizer/mesos/isolators/cgroups/mem.cpp > 2ddb9f4adbb879682cd39966ab974cf3fa32209c > src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp > 5eaf49f1f35c93ad4465adb6c9c9cf57b3a2c6ee > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp > b7ba00bc495001380f01737e46e8671ffe1c2ef7 > src/slave/containerizer/mesos/isolators/filesystem/linux.hpp > b8d47e8250a892fa333a0a966a0f38fe1f2816f2 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 8442e9c30612fa04f34130b9f967cb1414880ca6 > src/slave/containerizer/mesos/isolators/filesystem/posix.hpp > c3544aa313cbb185efb03bba59961cdf2b616a37 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca > src/slave/containerizer/mesos/isolators/filesystem/shared.hpp > 2e457015a0348a457581edf493877b71fab17090 > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp > 361ed6561bd5e2f75d026922def01f42b43d61c2 > src/slave/containerizer/mesos/isolators/namespaces/pid.hpp > c2d1455249618f9cd2e17dc2244b184d52b32eaf > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > d65c1593b44f4b21237581147e57e441ebf3160d > src/slave/containerizer/mesos/isolators/network/port_mapping.hpp > cbb94077d46d7b87ffc09b72e02269bc16f25f92 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 89bb36f936417de8169a2442729fbd7c9d60acb7 > src/slave/containerizer/mesos/isolators/posix.hpp > 7e1ebc2fada5a5e291e84c7044bdba9a71f4b42c > src/slave/containerizer/mesos/isolators/posix/disk.hpp > 31808c1e8199fbf2cea36c273860fdbf0a2388f8 > src/slave/containerizer/mesos/isolators/posix/disk.cpp > d971db09083faad08f3cf18c25a79245321d1d9a > src/tests/containerizer/isolator.hpp > e4101b188560bd857ea104f61f52f27c880e7731 > src/tests/containerizer/mesos_containerizer_tests.cpp > fe679354d04d68b68e168cd8c4eab23898f6532f > > Diff: https://reviews.apache.org/r/41113/diff/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh` was run on OSX and Ubuntu in order to test both the > posix and linux isolator code. Only expected test failures were observed. > Some of the failures on Ubuntu are `SlaveRecoveryTest`s, which is a bit > disconcerting, but this issue is tracked in MESOS-4025, and seems to be due > to artifacts left behind by previous tests. If I do: > > `GTEST_FILTER="" make check` > `sudo GTEST_FILTER="SlaveRecoveryTest*" bin/mesos-tests.sh` > > then all the `SlaveRecoveryTest`s pass. > > > Thanks, > > Greg Mann > >