-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41211/#review109844
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Park


On Dec. 10, 2015, 5:32 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41211/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Before this change the Http object was copied in to each HTTP routing
> lambda. If state were to be introduced, this could create hard to
> debug issues. Aggregating a single instance as a member of Master
> prevents these issues and simplifies access to communal code paths
> such as `authenticate`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
>   src/master/master.cpp 7acdc0a5d23a606eac2f37f4b7dd021c5a4fceb7 
> 
> Diff: https://reviews.apache.org/r/41211/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to