-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38171/#review110079
-----------------------------------------------------------
I would actually prefer we get rid of this class entirely.
1. I believe the variadic constructor for initialization doesn't give us much
value over `std::initializer_list`.
2. This class isn't used at all in the entire codebase except for once instance
of it in `src/log/log.cpp` which can simply be removed with:
```
- Set<UPID>((UPID) replica->pid()))),
+ {static_cast<UPID>(replica->pid())})),
```
since the member being initialized by this expression is `std::set` anyway.
After that, we just need to modify `set_tests.cpp` such that we test the added
operators such as `operator|`.
- Michael Park
On Sept. 8, 2015, 6:23 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38171/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 6:23 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp
> 85466dbb36b3ac545562eafe8041ad79993fdf9f
>
> Diff: https://reviews.apache.org/r/38171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
