----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38172/#review110080 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp (lines 46 - 49) <https://reviews.apache.org/r/38172/#comment169870> Why not just `std::unordered_set<Elem, Hash, Equal>(set.begin(), set.end())`? i.e. I don't see why `set.size()` should be the `bucket_size`. 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp (lines 69 - 71) <https://reviews.apache.org/r/38172/#comment169869> Same question as the `std::set` constructor. Why do we want `list.size()` to be the `bucket_size`? 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp (lines 73 - 83) <https://reviews.apache.org/r/38172/#comment169868> Let's not add this constructor. I don't think it adds much value (if at all) over `std::initializer_list`. - Michael Park On Sept. 8, 2015, 9:52 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38172/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 9:52 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3217 > https://issues.apache.org/jira/browse/MESOS-3217 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp > 1839d28638cd82dae10ba9b0f99c1a97cf34f9c9 > > Diff: https://reviews.apache.org/r/38172/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >