> On Dec. 13, 2015, 12:34 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1778-1794
> > <https://reviews.apache.org/r/41318/diff/1/?file=1161729#file1161729line1778>
> >
> >     This test also suffers from the same problem.
> >     Mind fixing this one as well?

Thanks for noticing that!


> On Dec. 13, 2015, 12:34 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp, line 1416
> > <https://reviews.apache.org/r/41318/diff/1/?file=1161729#file1161729line1416>
> >
> >     We capture the response, but don't use it later.
> >     Should we either:
> >     (1) not capture it
> >     (2) `ASSERT_AWAIT_READY(response)` before `AWAIT_READY(body)`
> >     (3) `ASSERT_AWAIT_READY(connection.send(request))`
> >     What are your thoughts?

Hm.. what I'll do to make this even more explicit is I'll add an 
`EXPECT_TRUE(response.isPending())`. We won't receive a response (that's the 
root of the issue here) because libprocess does not send one for this old-style 
pseudo-HTTP protocol.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41318/#review110106
-----------------------------------------------------------


On Dec. 12, 2015, 11:11 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41318/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> ProcessTest.Http1 hangs after a number of iterations because it uses
> http::post to do libprocess message passing but it uses the
> "User-Agent" header which means libprocess does not reply with a 202.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 3970dd83aa4ddd2cbe3664c157fc15943ab1182d 
> 
> Diff: https://reviews.apache.org/r/41318/diff/
> 
> 
> Testing
> -------
> 
> Ran with many iterations.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to