> On Dec. 14, 2015, 9:43 a.m., Benjamin Bannier wrote: > > docs/getting-started.md, line 57 > > <https://reviews.apache.org/r/41286/diff/1/?file=1160537#file1160537line57> > > > > Not a native speaker, but shouldn't it be `s/If/When` here. > > > > Also, please `s/and rerun/to run/`.
I think we could go either way with If/When, but I'll change it. I think we want to say 're-run', not just 'run' because we are talking about running it a second time after the upgrade. I agree with saying 'to' instead of 'and' though, that's just bad english. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41286/#review110184 ----------------------------------------------------------- On Dec. 14, 2015, 4:51 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41286/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 4:51 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-4118 > https://issues.apache.org/jira/browse/MESOS-4118 > > > Repository: mesos > > > Description > ------- > > The instructions for El Capitan are identical to Yosemite, with one > caveat: if upgrading from Yosemite to El Capitan, you need to rerun > 'xcode-select --install'. This commit adds a note of this. > > > Diffs > ----- > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41286/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
