> On Dec. 12, 2015, 10:49 p.m., James DeFelice wrote:
> > include/mesos/slave/container_logger.hpp, line 133
> > <https://reviews.apache.org/r/41002/diff/5/?file=1160533#file1160533line133>
> >
> >     I'm probably missing something here but why all the "executor or task" 
> > and "executor/task" references? Mesos doesn't spawn processes for tasks, it 
> > spawns processes for executors and then executors execute tasks (using 
> > threads, child procs, containers, whatever). Which means that this module 
> > is invoked for executors only -- not tasks, correct? The current docs read 
> > in a way that's misleading.

This logging module would would be executor-only for custom executors (the 
original name of the class was "ExecutorLogger").  However, two of the 
executors (and their tasks) provided by Mesos will be affected by the logging 
module:

* The command executor => spawns as an executor (process), but acts like a task.
* `mesos-docker-executor` => spawns as a process (or in a Docker container).  
Mesos launches command tasks (Docker containers) using this, and the resulting 
stdout/stderr goes into the sandbox currently.

The only logging Mesos does not necessarily control is tasks launched by custom 
executors.


> On Dec. 12, 2015, 10:49 p.m., James DeFelice wrote:
> > include/mesos/slave/container_logger.hpp, line 157
> > <https://reviews.apache.org/r/41002/diff/5/?file=1160533#file1160533line157>
> >
> >     It may be useful here to include the executor labels here so that, for 
> > example, frameworks could advertise additional information to logging 
> > modules. for example, things like additional log files (LOGFILEx=...), or a 
> > logs dir (LOGSDIRx=xyz) to monitor.
> >     
> >     It costs very little to include the executor labels here in the API and 
> > opens the door to more powerful modules down the road w/o needing to change 
> > the API to pass in additional context.

(Followed up in the design doc:)
https://docs.google.com/document/d/1Y8Sh_1eya0xI-djPmBZvqB-IVp1aaYSl-HCI6-2u5w4/


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41002/#review110113
-----------------------------------------------------------


On Dec. 11, 2015, 4:39 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41002/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 4:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Artem Harutyunyan, 
> and Thomas Rampelberg.
> 
> 
> Bugs: MESOS-4087
>     https://issues.apache.org/jira/browse/MESOS-4087
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The container logger is an agent module whose job is to take an executor or 
> task's stdout/stderr, and pipe it to some sink.
> 
> Existing executor and task stdout/stderr are piped into files ("stdout" and 
> "stderr") located in the executor's sandbox directory.
> This module aims to encompass this default behavior as well as allow more 
> sophisticated logging solutions.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41002/diff/
> 
> 
> Testing
> -------
> 
> This is added to the Makefile later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to