> On Dec. 14, 2015, 10:47 p.m., Guangya Liu wrote: > > src/master/master.cpp, lines 2829-2845 > > <https://reviews.apache.org/r/41305/diff/1/?file=1161526#file1161526line2829> > > > > How does this can resove overcommit issue? I think that the issue is > > still there? Another is that can you please add some comments here to > > explain the overcommit issue here?
The executor resources are cut from task's resource when add it into `TaskInfo`. Sure, I'll add some comments here. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review110233 ----------------------------------------------------------- On Dec. 12, 2015, 5:54 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41305/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 5:54 p.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian > Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-1718 > https://issues.apache.org/jira/browse/MESOS-1718 > > > Repository: mesos > > > Description > ------- > > MESOS-1718: move getExecutorInfo from slave to master > > > Diffs > ----- > > src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759 > src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 > src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 > src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 > > Diff: https://reviews.apache.org/r/41305/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
