----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41386/#review110399 -----------------------------------------------------------
src/tests/container_logger_tests.cpp (line 158) <https://reviews.apache.org/r/41386/#comment170228> Not against adding more tests, but we already have an identical test in the docker containerizer tests - Timothy Chen On Dec. 15, 2015, 2:26 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41386/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 2:26 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > ------- > > `ContainerLoggerTest.ROOT_DOCKER_DefaultToSandbox` is a regression test which > checks the existing logging behavior, in which the docker executor and > command task are both logged to the same file in the sandbox. > > > Diffs > ----- > > src/tests/container_logger_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41386/diff/ > > > Testing > ------- > > make check (Centos7) > > > Thanks, > > Joseph Wu > >
