-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review110474
-----------------------------------------------------------


Lookin good


include/mesos/mesos.proto (line 1569)
<https://reviews.apache.org/r/41380/#comment170405>

    Comment on its intended use, please.



include/mesos/mesos.proto (line 1609)
<https://reviews.apache.org/r/41380/#comment170404>

    Any chance that we'll want a non-string vip representation in the future? 
Maybe a more structured format, something for which we would prefer to make 
`message Vip` an alias of 'string'?
    Also, an intended usage comment would be appropriate here as well.


- Adam B


On Dec. 14, 2015, 7:35 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4114
>     https://issues.apache.org/jira/browse/MESOS-4114
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 
>   include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 
> 
> Diff: https://reviews.apache.org/r/41380/diff/
> 
> 
> Testing
> -------
> 
> make check, and make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to