> On Dec. 14, 2015, 8:07 p.m., Timothy Chen wrote: > > src/tests/environment.cpp, line 226 > > <https://reviews.apache.org/r/41378/diff/1/?file=1164065#file1164065line226> > > > > If we expect NULL to be a valid option we should make it an Option.
NULL is not a valid argument. But for some of these tests, I thought it would unnecessarily bloat the test code to create an unused `ContainerLogger`. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/#review110398 ----------------------------------------------------------- On Dec. 14, 2015, 6:14 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41378/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 6:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 3f199e622dd337cdbf32d4368f4ead424c39823c > src/tests/containerizer/docker_tests.cpp > d9e1345aea0ef9db0e50360e3993ef2708970298 > src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf > src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 > src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187 > > Diff: https://reviews.apache.org/r/41378/diff/ > > > Testing > ------- > > make (OSX, Centos7) > make check (OSX, Centos7) > sudo bin/mesos-tests.sh (Centos7) > > > Thanks, > > Joseph Wu > >
