----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41398/#review110510 -----------------------------------------------------------
Ship it! LGTM Also, can we add a bit more context into the description of the CR ? I know that the relevant JIRA has the details but it's cumbersome to open up the review from doing a `git log` and backtrace. - Anand Mazumdar On Dec. 15, 2015, 2:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41398/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 2:28 p.m.) > > > Review request for mesos, Neil Conway and Till Toenshoff. > > > Bugs: MESOS-4151 > https://issues.apache.org/jira/browse/MESOS-4151 > > > Repository: mesos > > > Description > ------- > > Added expectation for call to mocked function. > > > Diffs > ----- > > src/tests/slave_tests.cpp f19199344b8b542ebad1e59f4b97d8ca661aeb06 > > Diff: https://reviews.apache.org/r/41398/diff/ > > > Testing > ------- > > `make check` under OS X > > > Thanks, > > Benjamin Bannier > >
