> On Dec. 15, 2015, 2:44 a.m., Till Toenshoff wrote:
> > src/tests/hdfs_tests.cpp, lines 47-48
> > <https://reviews.apache.org/r/41384/diff/1/?file=1164258#file1164258line47>
> >
> >     This confused me initially as it seems this does not really apply.
> >     The tests serialize bash scripts into this file which emulates the 
> > hadoop client's logic while operating on the local filesystem.

My bad. I forgot to update the comments.


> On Dec. 15, 2015, 2:44 a.m., Till Toenshoff wrote:
> > src/tests/hdfs_tests.cpp, line 64
> > <https://reviews.apache.org/r/41384/diff/1/?file=1164258#file1164258line64>
> >
> >     Missing test heading comments in this case actually seems to be fine to 
> > me, given the easy to grasp nature and the expected repetition when 
> > insisting on doing so for every single one of these.

Done.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41384/#review110373
-----------------------------------------------------------


On Dec. 15, 2015, 1:27 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41384/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
>     https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for HDFS client.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/tests/hdfs_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41384/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to