----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41424/#review110679 -----------------------------------------------------------
Looks like this might be problematic on a clean build (reviewbot error on the next review): ``` make[7]: *** No rule to make target `picojson-1.3.0/picojson.h', needed by `all-am'. Stop. make[7]: *** Waiting for unfinished jobs.... ``` - Joseph Wu On Dec. 15, 2015, 4:10 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41424/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 4:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Niklas > Nielsen. > > > Bugs: MESOS-3909 > https://issues.apache.org/jira/browse/MESOS-3909 > > > Repository: mesos > > > Description > ------- > > The Stout JSON API depends on picojson.h, so we need to install it > to be able to build Mesos modules outside the Mesos source tree. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 04d0fa324bf6eab98a51fc08298b9da2992d29d1 > > Diff: https://reviews.apache.org/r/41424/diff/ > > > Testing > ------- > > Build an external module that implicitly depends on picojson.h > > > Thanks, > > James Peach > >
