----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41004/#review110832 -----------------------------------------------------------
Ship it! src/examples/test_container_logger_module.cpp (line 56) <https://reviews.apache.org/r/41004/#comment170838> s/createContainerLogger/[](const Parameters& parameters) { Try<ContainerLogger*> result = SandboxContainerLogger::create(None()); if (result.isError()) { return NULL; } return result.get(); }/ src/slave/container_logger.cpp (line 37) <https://reviews.apache.org/r/41004/#comment170841> s/containerLogger/logger/ = NULL; - Benjamin Hindman On Dec. 15, 2015, 8:39 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41004/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 8:39 p.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem > Harutyunyan. > > > Bugs: MESOS-4087 > https://issues.apache.org/jira/browse/MESOS-4087 > > > Repository: mesos > > > Description > ------- > > Modularizes the `ContainerLogger` interface and adds the > `SandboxContainerLogger` as the default. > > > Diffs > ----- > > include/mesos/module/container_logger.hpp PRE-CREATION > src/Makefile.am acd17de04bce81f1d0550abfa0f43dec1a25fe7c > src/examples/test_container_logger_module.cpp PRE-CREATION > src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6 > src/slave/container_logger.cpp PRE-CREATION > src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6 > src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828 > > Diff: https://reviews.apache.org/r/41004/diff/ > > > Testing > ------- > > make > > Tests are modified and run later in the review chain. > > > Thanks, > > Joseph Wu > >
