----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41111/#review110847 -----------------------------------------------------------
Ship it! src/tests/container_logger_tests.cpp (line 78) <https://reviews.apache.org/r/41111/#comment170860> s/agent_flags/flags/ src/tests/container_logger_tests.cpp (line 87) <https://reviews.apache.org/r/41111/#comment170861> s/agent/slave/ src/tests/container_logger_tests.cpp (lines 114 - 116) <https://reviews.apache.org/r/41111/#comment170862> This fits on one line, copy paste bug? src/tests/container_logger_tests.cpp (line 129) <https://reviews.apache.org/r/41111/#comment170863> s/sandboxPath/sandboxDirectory/ - Benjamin Hindman On Dec. 12, 2015, 12:39 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41111/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 12:39 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4087 > https://issues.apache.org/jira/browse/MESOS-4087 > > > Repository: mesos > > > Description > ------- > > `ContainerLoggerTest.DefaultToSandbox` is a regression test which checks the > existing logging behavior, prior to introducing/using the `ContainerLogger` > module. As of this patch, the `ContainerLogger` is not actually being tested. > > > Diffs > ----- > > src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e > src/tests/container_logger_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41111/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
