> On Dec. 16, 2015, 10:03 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, lines 183-184
> > <https://reviews.apache.org/r/41407/diff/1/?file=1164939#file1164939line183>
> >
> >     s/stagingLayerPath/layerPath/

I am totally agreed with this change. But we have another layerPath above in 
this method (not causing any error thougg), which is confusing. Do you think it 
is good to change:
s/layerPath/layerTarPath above on Line145 & Line180


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41407/#review110705
-----------------------------------------------------------


On Dec. 16, 2015, 6:38 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41407/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 6:38 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
>     https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Save all docker image information on disk instead of 
> rootfs only.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41407/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to