----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/#review110931 -----------------------------------------------------------
@Guangya, there's some my comments: - add a role parameter for `allocationSlack`, so we can remove role's reserved resources - add `flatten(RevocableInfo::Type)` to avoid send `RevocableInfo::Type` by protobuf's func - not sure how to define `usageSlack`, I'd suggest to remove it; and add it back when necessary, just as what we have done to `noRevoable` - Klaus Ma On Dec. 17, 2015, 5:43 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41334/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 5:43 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Bugs: MESOS-4146 > https://issues.apache.org/jira/browse/MESOS-4146 > > > Repository: mesos > > > Description > ------- > > Added helper functions to filter allocation slack resources. > > > Diffs > ----- > > include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d > include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa > src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717 > > Diff: https://reviews.apache.org/r/41334/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
