----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41337/#review110935 -----------------------------------------------------------
src/slave/slave.cpp (line 4860) <https://reviews.apache.org/r/41337/#comment170938> Honestly, I'd suggest to update `shutdownExecutor` to return future; so slave'll wait all future finished before `runTask`. LaunchTask periodic does not make sense :). - Klaus Ma On Dec. 17, 2015, 5:22 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41337/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 5:22 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4148 > https://issues.apache.org/jira/browse/MESOS-4148 > > > Repository: mesos > > > Description > ------- > > Set task as TASK_LOST if not enough allocation slack resources. > > > Diffs > ----- > > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe > > Diff: https://reviews.apache.org/r/41337/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
