----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41488/#review111026 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/message.proto (line 51) <https://reviews.apache.org/r/41488/#comment171020> Ditto here. s/docker::V1DockerImageManifest/docker::v1::ImageManifest/ src/slave/containerizer/mesos/provisioner/docker/message.proto (line 52) <https://reviews.apache.org/r/41488/#comment171023> What's this field. I couldn't find it in the v1 spec? Also, why 'architecture', 'authors', etc are not in this protobuf? - Jie Yu On Dec. 17, 2015, 2:39 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41488/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 2:39 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4186 > https://issues.apache.org/jira/browse/MESOS-4186 > > > Repository: mesos > > > Description > ------- > > Provisioner: Added docker v1 manifest protobuf message. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/message.proto > 5c032701671b275d86c6d9276791a46df814396c > > Diff: https://reviews.apache.org/r/41488/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
