> On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/sandbox.cpp, line 55 > > <https://reviews.apache.org/r/41003/diff/6/?file=1165102#file1165102line55> > > > > Is this comment useful? Is there something else here you want to > > capture?
Removed this comment in favor of a better header-file comment. > On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/sandbox.cpp, line 72 > > <https://reviews.apache.org/r/41003/diff/6/?file=1165102#file1165102line72> > > > > Can we put a newline before this? Or: > > > > info.environment = environment.get({}); Changed to `getOrElse`. > On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/sandbox.hpp, line 44 > > <https://reviews.apache.org/r/41003/diff/6/?file=1165101#file1165101line44> > > > > Can we leave a comment of what this provides? And that it's the default? Done! - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41003/#review110827 ----------------------------------------------------------- On Dec. 17, 2015, 12:14 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41003/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 12:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem > Harutyunyan. > > > Bugs: MESOS-4087 > https://issues.apache.org/jira/browse/MESOS-4087 > > > Repository: mesos > > > Description > ------- > > This implementation mirrors how executor/task stdout/stderr is currently > saved to plain files. > > > Diffs > ----- > > src/slave/container_loggers/sandbox.hpp PRE-CREATION > src/slave/container_loggers/sandbox.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41003/diff/ > > > Testing > ------- > > This is added to the Makefile later in the review chain. > > > Thanks, > > Joseph Wu > >
