-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41487/#review111204
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 73)
<https://reviews.apache.org/r/41487/#comment171305>

    No need to do this in this patch. Let rename this method to be 
'getImageManifest'



src/slave/containerizer/mesos/provisioner/docker/spec.hpp (line 35)
<https://reviews.apache.org/r/41487/#comment171303>

    s/validateManifest/validate/



src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 33)
<https://reviews.apache.org/r/41487/#comment171304>

    Ditto.


- Jie Yu


On Dec. 18, 2015, 9:19 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41487/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 9:19 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4186
>     https://issues.apache.org/jira/browse/MESOS-4186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provisioner: Changed docker v2 manifest naming.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/slave/containerizer/mesos/provisioner/docker/message.hpp 
> 162e4c689bba832e523ff6b7d4e1e3c8e6713803 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 
> 5c032701671b275d86c6d9276791a46df814396c 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> 9b02b6ff6dc5c6e8aabdc4ac0aa4df337764ef30 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e69bab43d5f5359cfd8eb4cb7c5ad4a1d22c4e05 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 89f61c20e52e5eff8d8e92748f03b3b461516cd2 
>   src/slave/containerizer/mesos/provisioner/docker/spec.hpp 
> e674b6f2e705f8b3e49770560eeab4c127473f94 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41487/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to