-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41474/#review111352
-----------------------------------------------------------



3rdparty/libprocess/README.md (line 107)
<https://reviews.apache.org/r/41474/#comment171508>

    "a future"
    
    "When the event occurs,"
    
    "all such" => "all"



3rdparty/libprocess/README.md (line 111)
<https://reviews.apache.org/r/41474/#comment171509>

    In what sense is the "decision postponed"? By using `defer`, aren't I 
immediately deciding that the `dispatch` will be done asynchronously?



3rdparty/libprocess/README.md (line 149)
<https://reviews.apache.org/r/41474/#comment171510>

    I might just say something like "Thus, fullfilling a future can result in 
executing callbacks either synchronously or asynchronously, depending on 
whether `defer` is used when the callback is registered."
    
    (IMO talking about "synchronous execution of callbacks" makes things a bit 
more confusing.)



3rdparty/libprocess/README.md (line 151)
<https://reviews.apache.org/r/41474/#comment171511>

    Weird sentence to end the paragraph. What is "this"? What is the pattern, 
and why is it useful?



3rdparty/libprocess/README.md (line 170)
<https://reviews.apache.org/r/41474/#comment171512>

    Clarify what "it's" means here. Something like: "The important thing is 
that the process that registers the callback is (likely) different from the 
process that fulfills the future."



3rdparty/libprocess/README.md (line 173)
<https://reviews.apache.org/r/41474/#comment171513>

    What "underlying implementation"?



3rdparty/libprocess/README.md (line 176)
<https://reviews.apache.org/r/41474/#comment171514>

    Clarify what the data race is.



3rdparty/libprocess/README.md (line 178)
<https://reviews.apache.org/r/41474/#comment171515>

    I'm a bit confused at this point. If the point is just to make sure that 
the callback is invoked in the context of a given process (e.g., `self()`) and 
not in the context of the process that satisfies the future, why can't I just 
use `dispatch()`?



3rdparty/libprocess/README.md (line 211)
<https://reviews.apache.org/r/41474/#comment171516>

    What is this used for?


- Neil Conway


On Dec. 19, 2015, 1:26 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41474/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2015, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, 
> and Neil Conway.
> 
> 
> Bugs: MESOS-3996
>     https://issues.apache.org/jira/browse/MESOS-3996
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for `defer` in libprocess README.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5 
> 
> Diff: https://reviews.apache.org/r/41474/diff/
> 
> 
> Testing
> -------
> 
> Viewed the markdown in a branch on GitHub: 
> https://github.com/mesosphere/mesos/tree/defer_docs/3rdparty/libprocess
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to