> On 十二月 19, 2015, 3:58 a.m., Guangya Liu wrote:
> > docs/roles.md, line 29
> > <https://reviews.apache.org/r/41408/diff/2/?file=1171263#file1171263line29>
> >
> >     One minor comment: The whitelist is already a keyword when mesos master 
> > star up, not sure if this may bring some confusion for end users, what 
> > about using _role list_ instead of _role whitelist_?
> 
> Neil Conway wrote:
>     I'd vote we stick with "role whitelist"; the other common usage in Mesos 
> is a "slave whitelist", and so it should be clear by context (as well as the 
> use of "role" vs. "slave" + whitelist) which one is being referred to.

Yes, but the difference is that the "slave/agent whitelist" is using 
"whitelist" as flag 
(https://github.com/apache/mesos/blob/master/src/master/flags.cpp#L153-L157), 
but "role whitelist" is using "role" as flag. When I first read this document, 
I was a bit confused with _role whitelist_, because I was always thinking 
_whitelist_ is "slave whitelist". ;-) But after finish the document, I was 
clear about _role whitelist_. It depends on you to make the decision because I 
did not mark this as an issue but only a question. Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41408/#review111356
-----------------------------------------------------------


On 十二月 18, 2015, 8 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41408/
> -----------------------------------------------------------
> 
> (Updated 十二月 18, 2015, 8 p.m.)
> 
> 
> Review request for mesos, Adam B and Yongqiao Wang.
> 
> 
> Bugs: MESOS-4085
>     https://issues.apache.org/jira/browse/MESOS-4085
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated documentation for implicit roles.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 388b8b91df6fce826413649b0a1480af3f78e918 
>   docs/attributes-resources.md 3c5f2776d44a050ee3ac9967dd0ba0253b9c4558 
>   docs/configuration.md c75f56ce849f6960b3b6246bfa6949156a82eabb 
>   docs/roles.md 459d70717f4a0bdd921bb18b6ddc2505b6fc596e 
>   docs/upgrades.md 7c1f1814680078380ca33bbc27421675ffe61d60 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/41408/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to