----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41166/#review111423 -----------------------------------------------------------
Ship it! src/slave/containerizer/containerizer.cpp (line 174) <https://reviews.apache.org/r/41166/#comment171600> Suggestion to make things even more explicit: --- The external containerizer does not support custom container logger modules, i.e., you can't set both the '--isolation=external' and '--container_logger=...' flags. --- Same below as well (but slightly different flags). - Benjamin Hindman On Dec. 14, 2015, 11:47 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41166/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 11:47 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4088 > https://issues.apache.org/jira/browse/MESOS-4088 > > > Repository: mesos > > > Description > ------- > > Using the `ContainerLogger` with the `ExternalContainerizer` is not supported > at the moment. We explicitly disallowed the combination, so that there are > no incorrect assumptions. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp > dcdf98fea4ca6f96658886db5d09c99f3bff501d > > Diff: https://reviews.apache.org/r/41166/diff/ > > > Testing > ------- > > This is tested later in the review chain. > > > Thanks, > > Joseph Wu > >
