----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/#review111428 -----------------------------------------------------------
Ship it! This looks fine, assuming that we actually need `CreateContainerLogger` (see below). src/tests/containerizer/filesystem_isolator_tests.cpp (line 174) <https://reviews.apache.org/r/41169/#comment171605> I still haven't seen why you need `CreateContainerLogger` instead of just `ContainerLogger::create`, just like we use `LinuxLauncher::create` above ... but I'm sure I'll see it soon enough! ;-) - Benjamin Hindman On Dec. 15, 2015, 8:40 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41169/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 8:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4088 > https://issues.apache.org/jira/browse/MESOS-4088 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/containerizer/filesystem_isolator_tests.cpp > f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 > src/tests/containerizer/mesos_containerizer_tests.cpp > fe679354d04d68b68e168cd8c4eab23898f6532f > > Diff: https://reviews.apache.org/r/41169/diff/ > > > Testing > ------- > > make (OSX, Centos7, Ubuntu 14, Debian 8) > make check (OSX, Centos7, Ubuntu 14, Debian 8) > sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8) > > > Thanks, > > Joseph Wu > >
