----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41609/#review111499 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Dec. 21, 2015, 4:58 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41609/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 4:58 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Cleaned up formatting for multiple inheritance. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > 7c1197ed03df8b5d77d26307560535f9ff5bf350 > src/tests/hierarchical_allocator_tests.cpp > 88bb7e987c471587d46e15082fe1149fd94db5d6 > src/tests/registrar_tests.cpp c5022233fa88c4d8578055bc4812055b4cb9060d > > Diff: https://reviews.apache.org/r/41609/diff/ > > > Testing > ------- > > None: not a functional change. > > I've grepped the code base to find out what is the common wrapping here. > "tests/executor_http_api_tests.cpp:74" uses the proposed wrapping: > ``` > class ExecutorHttpApiTest > : public MesosTest, > public WithParamInterface<ContentType> {}; > ``` > > It also seems to be consistent another similar syntax pattern (c-tor > initialization list), for example see > "libprocess/include/process/http.hpp" > "src/slave/master.cpp:118" > > > Thanks, > > Alexander Rukletsov > >
