----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review111507 -----------------------------------------------------------
Ship it! src/master/master.hpp (line 945) <https://reviews.apache.org/r/39492/#comment171708> "quota settings" sounds like a new term we haven't used before. Let's be repetitive, but predictable. How about "Returns a list of set quotas". If you have something in mind how the response will be extended, feel free to add a `TODO`. src/master/quota_handler.cpp (line 474) <https://reviews.apache.org/r/39492/#comment171709> s/entry/an entry? - Alexander Rukletsov On Dec. 21, 2015, 2:56 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39492/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 2:56 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-4013 > https://issues.apache.org/jira/browse/MESOS-4013 > > > Repository: mesos > > > Description > ------- > > Added status handling for quota master endpoint. > > > Diffs > ----- > > include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed > src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 > src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 > > Diff: https://reviews.apache.org/r/39492/diff/ > > > Testing > ------- > > Tests are in next Review. > > > Thanks, > > Joerg Schad > >
