-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review111589
-----------------------------------------------------------

Ship it!



src/tests/persistent_volume_tests.cpp (line 68)
<https://reviews.apache.org/r/41613/#comment171807>

    Usually, we capitalize constants, so how about `DEFAULT_ROLE`?



src/tests/persistent_volume_tests.cpp (lines 682 - 684)
<https://reviews.apache.org/r/41613/#comment171808>

    I always find increasing line numbers unfortunate : ). What do you think 
about the following formatting:
    ```
      Resources taskResources = Resources::parse(
          "cpus:1;mem:128;disk(" + defaultRole + "):32").get() + volume;
    ```


- Alexander Rukletsov


On Dec. 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `defaultRole` constant to persistent volume tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to