-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review111597
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (line 578)
<https://reviews.apache.org/r/39614/#comment171815>

    The ReviewBot is failing because `quotaResources` must be flattened.
    
    Also, why do you use `ASSERT_*` instead of `EXPECT_*` which are used 
throughout the test?


- Alexander Rukletsov


On Dec. 22, 2015, 10:19 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 10:19 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4218
>     https://issues.apache.org/jira/browse/MESOS-4218
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to