> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 167 > > <https://reviews.apache.org/r/41593/diff/2/?file=1173648#file1173648line167> > > > > Is the `int32_t`, `uint32_t`, and `float` overloads necessary?
With only overloads for `int64_t`, `uint64_t`, `double`, passing `0` for example is ambiguous between `int64_t` and `uint64_t`. > On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 624 > > <https://reviews.apache.org/r/41593/diff/2/?file=1173648#file1173648line624> > > > > Since this is in the `internal` namespace, can we > > s/jsonify_impl/jsonify/ please? We sure could. I initially had it named `jsonify` and had it returning `Proxy`, but when I changed it to `std::function`, I thought `jsonify_impl` would be a better name for it. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review111575 ----------------------------------------------------------- On Dec. 22, 2015, 8:23 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41593/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 8:23 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/README.md > a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41593/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
