-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41665/#review111684
-----------------------------------------------------------


By changing the default registry to "in_memory", you also have to change (and 
you do) the `registry_strict` flag to `false`. I believe this may impact some 
tests. Obviously it does, since you explicitly fall back to strict 
"replicated_log" in some tests. My questions are:
  - When is it fine to use a non-strict registry and when not?
  - How did you figure out the tests that require a strict registry?
I think it will be great if you can leave such comment in the review 
description.

- Alexander Rukletsov


On Dec. 22, 2015, 10:45 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41665/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 10:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-1757
>     https://issues.apache.org/jira/browse/MESOS-1757
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This speeds up running the tests by ~13%.
> It can have a much larger impact when running specific test suites
> using 'gtest_repeat'.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/mesos.cpp 11ca0519ad0dad44328b6ebdf52c5356fda818b7 
> 
> Diff: https://reviews.apache.org/r/41665/diff/
> 
> 
> Testing
> -------
> 
> With patch:
> ```
> Command being timed: "./bin/mesos-tests.sh"
> User time (seconds): 42.76
> System time (seconds): 10.21
> Percent of CPU this job got: 7%
> Elapsed (wall clock) time (h:mm:ss or m:ss): 11:15.21
> ```
> before:
> ```
> Command being timed: "./bin/mesos-tests.sh"
> User time (seconds): 52.58
> System time (seconds): 11.78
> Percent of CPU this job got: 8%
> Elapsed (wall clock) time (h:mm:ss or m:ss): 12:48.42
> ```
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to