> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 1 > > <https://reviews.apache.org/r/39019/diff/9/?file=1174985#file1174985line1> > > > > Does it have to be in makefile.am? Or this is used only on Windows, > > which is CMake at this time.
Good catch! You're right, we should put it there (because we include things like `Windows.hpp`), but you're also right that it doesn't _need_ to be there, because someone on a Unix would never need to update their build if this file was altered. > On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 104 > > <https://reviews.apache.org/r/39019/diff/9/?file=1174985#file1174985line104> > > > > Can you check the semnatic of opendir() function? I'm under the > > imression that the first file is found after a susequential readdir() call. > > Is the intent to change the behaviour on Windows? I believe this implementation is correct. The POSIX specification[1] says: "The directory stream is positioned at the first entry." Do you read this differently? [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/opendir.html - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review111717 ----------------------------------------------------------- On Dec. 23, 2015, 2:15 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39019/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 2:15 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, and Joseph Wu. > > > Bugs: MESOS-3441 > https://issues.apache.org/jira/browse/MESOS-3441 > > > Repository: mesos > > > Description > ------- > > Windows: Added dirent compat code for non-Unix systems. > > > Diffs > ----- > > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd > > Diff: https://reviews.apache.org/r/39019/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
