-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41715/#review111903
-----------------------------------------------------------

Ship it!


Verified that the parse method handles some conner cases well. :)


3rdparty/libprocess/src/tests/http_tests.cpp (lines 1204 - 1207)
<https://reviews.apache.org/r/41715/#comment172198>

    Should we use `EXPECT_` here?
    
    It does not impact on this test result, but we may not expect each of them 
to yield a fatal failure. (Understand that the test passed though, but it can 
become an example to someone else, and we do want tests continue to run).



3rdparty/libprocess/src/tests/http_tests.cpp (lines 1211 - 1214)
<https://reviews.apache.org/r/41715/#comment172201>

    Ditto.



3rdparty/libprocess/src/tests/http_tests.cpp (lines 1218 - 1221)
<https://reviews.apache.org/r/41715/#comment172200>

    Ditto.


- Gilbert Song


On Dec. 25, 2015, 12:10 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41715/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2015, 12:10 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support parsing url in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 19261502be220aaa40add7ce30a9b2b65d1d9fdc 
> 
> Diff: https://reviews.apache.org/r/41715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to