> On Dec. 28, 2015, 8:02 p.m., Jojy Varghese wrote:
> > 3rdparty/libprocess/src/http.cpp, line 183
> > <https://reviews.apache.org/r/41715/diff/2/?file=1176450#file1176450line183>
> >
> >     Have we considered using a regex parser for doing this? C++11 regex 
> > support is added since gcc 4.9 and has been in clang for sometime now.

We can do this later, I took the toURL method you did in the registry client, 
made it more general moved it into libprocess for now.
I can add a TODO later for making it better.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41715/#review112061
-----------------------------------------------------------


On Dec. 26, 2015, 8:24 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41715/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 8:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support parsing url in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 19261502be220aaa40add7ce30a9b2b65d1d9fdc 
> 
> Diff: https://reviews.apache.org/r/41715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to