-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41713/#review112105
-----------------------------------------------------------

Ship it!


Ship It!


src/uri/fetcher.cpp (line 57)
<https://reviews.apache.org/r/41713/#comment172417>

    Missing starting single quote



src/uri/fetcher.cpp (line 63)
<https://reviews.apache.org/r/41713/#comment172418>

    I think we should warn when there is already a plugin for the scheme.


- Timothy Chen


On Dec. 28, 2015, 6:07 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41713/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, Ian Downes, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3925
>     https://issues.apache.org/jira/browse/MESOS-3925
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HDFS URI fetcher plugin. This patch also adjusted the plugin 
> initialization logic so that flags can be used to initialize each plugin.
> 
> 
> Diffs
> -----
> 
>   include/mesos/uri/fetcher.hpp 6cf7b37818ceff64ffe56138ebd4bc7e2abe5a7c 
>   include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 
>   src/Makefile.am 8af0115caa67ac8f3193d8f0d0f1a4ae739af275 
>   src/tests/uri_fetcher_tests.cpp d54a7e7b08a741b1d5d371c11747681ae4ddef98 
>   src/uri/fetcher.hpp PRE-CREATION 
>   src/uri/fetcher.cpp 8bd7cf3d638a737c40183294cb4548a4851e0886 
>   src/uri/fetchers/curl.hpp 401829d1990ec817ea069ce45f902c521cd1a937 
>   src/uri/fetchers/curl.cpp 6c607a6a800374b6e14b37bfdc6b04e7a4e87892 
>   src/uri/fetchers/hadoop.hpp PRE-CREATION 
>   src/uri/fetchers/hadoop.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41713/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to