-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41714/#review112108
-----------------------------------------------------------



src/tests/uri_fetcher_tests.cpp (line 165)
<https://reviews.apache.org/r/41714/#comment172423>

    ValidUri sounded like it was passed a vaild uri format instead of existing 
file. How about FetchExistingFile and FetchNonExistingFile?


- Timothy Chen


On Dec. 28, 2015, 6:07 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41714/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, Ian Downes, Timothy Chen, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-3925
>     https://issues.apache.org/jira/browse/MESOS-3925
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for HDFS URI fetcher plugin.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8af0115caa67ac8f3193d8f0d0f1a4ae739af275 
>   src/tests/uri_fetcher_tests.cpp d54a7e7b08a741b1d5d371c11747681ae4ddef98 
>   src/uri/schemes/hdfs.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41714/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to