-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review112343
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 186)
<https://reviews.apache.org/r/41705/#comment172819>

    Can you do the following instead?
    ```
    path = path::join(info->directory, path, "");
    ```



src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 301)
<https://reviews.apache.org/r/41705/#comment172821>

    We may want to report volume usage through ResourceStatistics. This can be 
a separate ticket.



src/tests/disk_quota_tests.cpp (line 221)
<https://reviews.apache.org/r/41705/#comment172824>

    Do we still need this with implicit roles?


- Jie Yu


On Dec. 28, 2015, 7:36 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 7:36 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
>     https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> d971db09083faad08f3cf18c25a79245321d1d9a 
>   src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
> 
> Diff: https://reviews.apache.org/r/41705/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER='DiskQuotaTest*' make check -j8
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to