-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/#review112496
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 113)
<https://reviews.apache.org/r/41869/#comment172949>

    Can we make this ```mutable``` and keep all the methods ```const``` ?



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 254)
<https://reviews.apache.org/r/41869/#comment172947>

    Since realm is needed only for tokenmanager creation, this could be moved 
inside the block starting at L260.



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (lines 262 
- 263)
<https://reviews.apache.org/r/41869/#comment172948>

    These 2 lines can be combined as: 
    
    ``` 
    Try<http::URL> realmUrl = http::URL::parse(attributes.at("realm"));
    ```


- Jojy Varghese


On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently Docker auth server is being configured via docker_auth_server flag, 
> but we should actually get the docker auth server information from docker 
> registry. This allows us to remove one flag and also support both public and 
> private docker registry.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
>   src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41869/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to